Deprecate backend_qt.qApp.#22503
Merged
Merged
Conversation
6 tasks
oscargus
approved these changes
Feb 22, 2022
6 tasks
This global has subtly different semantics from QtWidgets.QApplication.instance() (it is only updated when the private _create_qApp is called), and therefore seems not worth exposing.
tacaswell
approved these changes
Mar 22, 2022
Member
tacaswell
left a comment
tacaswell
left a comment
There was a problem hiding this comment.
I do not want to merge because I pushed a commit of tests.
timhoffm
approved these changes
Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This global has subtly different semantics from
QtWidgets.QApplication.instance() (it is only updated when the private
_create_qApp is called), and therefore seems not worth exposing.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).