Skip to content

Drop non-significant zeros from ps output.#21697

Merged
jklymak merged 1 commit into
matplotlib:mainfrom
anntzer:psrealg
Nov 22, 2021
Merged

Drop non-significant zeros from ps output.#21697
jklymak merged 1 commit into
matplotlib:mainfrom
anntzer:psrealg

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Nov 21, 2021

:g format drops non significant zeros, and also uses scientific
notation as appropriate; PostScript explicitly supports scientific
notation (PostScript Language Reference section 3.2).

The point is mostly to improve the legibility of the PostScript output.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

`:g` format drops non significant zeros, and also uses scientific
notation as appropriate; PostScript explicitly supports scientific
notation (PostScript Language Reference section 3.2).

The point is mostly to improve the legibility of the PostScript output.
@jklymak
Copy link
Copy Markdown
Member

jklymak commented Nov 22, 2021

Do we know if anyone is doing text-file diffs on ps files as part of a test suite? This will break those

@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Nov 22, 2021

I don't know for PS, but I changed all the glyph embeddings for SVG in #17669, and although this seems to have broken some non-compliant SVG renderers (#20910), no one complained about text diffs specifically.

@jklymak jklymak merged commit bf40e89 into matplotlib:main Nov 22, 2021
@anntzer anntzer deleted the psrealg branch November 22, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants