Backport #21429 from jklymak/doc-use-mpl-sphinx#21461
Merged
Merged
Conversation
DOC: use mpl-sphinx-theme for navbar, social, logo
jklymak
changed the title
timhoffm
reviewed
Oct 25, 2021
| numpydoc>=0.8 | ||
| packaging>=20 | ||
| pydata-sphinx-theme>=0.6.0 | ||
| pyparsing<3.0.0 |
jklymak
commented
Oct 25, 2021
jklymak
commented
Oct 26, 2021
Member
Author
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
The only "controversial" thing here is back porting environment.yml @timhoffm I think you introduced this file - is there any reason to not back port it? I admit I am back porting it due to poor cherry-picking skills, but left it in there anyway.
timhoffm
approved these changes
Oct 26, 2021
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Backporting environment.yml is not really necessary. The main use is creating a dev environement for the current master. OTOH future version branches will have their then-current environment.yml. So it's also no harm to have the backport in 3.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOC: use mpl-sphinx-theme for navbar, social, logo
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).