Fix legend edgecolor face#20260
Closed
jklymak wants to merge 3 commits into
Closed
Conversation
55c24d1 to
1cb7a78
Compare
jklymak
commented
May 18, 2021
| return None | ||
| edgecolor = getattr(orig_handle, '_original_edgecolor', | ||
| orig_handle.get_edgecolor()) | ||
| if edgecolor == 'face': |
Member
Author
There was a problem hiding this comment.
Note we can't just get rid of the line before as it causes some hatching tests to fail for some reason...
Member
|
#8575 put in the mysterious fix for the hatching. Strangely, although |
Member
Author
|
Thanks - we could also do Or fix it in |
Member
Author
|
Third commit checks for no colors... |
efiring
added a commit
to efiring/matplotlib
that referenced
this pull request
May 19, 2021
Closes matplotlib#20258. Alternative to matplotlib#20260.
efiring
added a commit
to efiring/matplotlib
that referenced
this pull request
May 19, 2021
Member
Author
|
Close in favour of #20265 |
jklymak
pushed a commit
to jklymak/matplotlib
that referenced
this pull request
Jun 13, 2021
Closes matplotlib#20258. Alternative to matplotlib#20260.
jklymak
pushed a commit
to jklymak/matplotlib
that referenced
this pull request
Jun 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #20258
Passing
'face'to a polygon that would show up in the legend would not be recognized. Now it is...before:
Now:
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).