Ignore CLOSEPOLY vertices when computing dataLim from patches#19088
Merged
Conversation
QuLogic
reviewed
Dec 9, 2020
jsberg-bnl
force-pushed
the
issue-19078
branch
from
35eba09 to
edd8a64
Compare
QuLogic
reviewed
Dec 22, 2020
jsberg-bnl
force-pushed
the
issue-19078
branch
from
edd8a64 to
039e416
Compare
timhoffm
approved these changes
Dec 23, 2020
QuLogic
approved these changes
Dec 24, 2020
Member
|
Thanks @jsberg-bnl ! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
CLOSEPOLY verticies are not actual points in a path, but _update_patch_limits uses them anyhow when computing dataLim. This patch removes the CLOSEPOLY vertices from the list of vertices used in the computation. Fixes #19078.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).