Remove Artist.eventson and Container.eventson#18910
Merged
Merged
Conversation
Member
|
No deprecation? |
Member
Author
|
This has only ever existed as an attribute set in Given that, it's extremely unlikely anybody is using it, and I dare removing without deprecation fuss. |
QuLogic
approved these changes
Nov 10, 2020
timhoffm
force-pushed
the
remove-eventson
branch
from
021336a to
1e11c7d
Compare
anntzer
previously requested changes
Nov 10, 2020
Contributor
anntzer
left a comment
anntzer
left a comment
There was a problem hiding this comment.
messed up rebase. anyone can dismiss once fixed.
timhoffm
force-pushed
the
remove-eventson
branch
from
1e11c7d to
5e5918a
Compare
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Feb 2, 2026
The attribute `eventson` was introduced in 79aa291. While it was set on and off in various places, there has never been any code that made logic depend on its state. The attribute itself was removed in matplotlib#18910, but its toggling through the context manager was overlooked there. Note: There is another `eventson` in widgets.py, which is completely independent on this here, because widgets are not Artists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
They are unused.
Closes #4877.