Also fix tk key mapping, following the same strategy as for gtk.#18693
Merged
Conversation
QuLogic
requested changes
Oct 9, 2020
Member
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
While this fixes the number pad, it breaks the arrow keys.
anntzer
force-pushed
the
tkkeys
branch
2 times, most recently
from
c133aa3 to
577f324
Compare
Contributor
Author
|
good catch, now fixed. Also found that I needed to fix pageup/pagedown, done. |
QuLogic
approved these changes
Oct 10, 2020
Member
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
Seems to work, but given the removed comments in the code, it might be nice to get someone on macOS to test.
Some keys are still misreported, e.g. numpad keyreleases (keypresses are fine), but I think this is already an improvement.
Contributor
Author
|
both comments handled, agreed physically testing on a mac would be nice. |
timhoffm
approved these changes
Oct 10, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some keys are still misreported, e.g. numpad keyreleases (keypresses are
fine), but I think this is already an improvement.
(followup to #17791)
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).