backend_ps: Do not write to a temporary file unless using an external distiller#1826
Conversation
|
This looks fine to me. |
|
Is there any documentation needed for this change? Is the |
|
I don't think it's new functionality, only that it will now write directly to a file, rather than to a temporary and then moved. I suppose if someone was relying on the old behavior that may be a problem -- but this change I think ultimately makes things less surprising. |
… distiller. If ps.usedistiller is omitted, writes directly to the output file, instead of creating a temporary file and subsequently copying it to the output. This is more efficient, and also works on restricted platforms such as Google App Engine, which are unable to provide a writable temporary file system.
|
To clarify, you cannot write " I don't see how someone could be broken by this change. There is no noticeable difference between the old and new behaviour unless you are watching the temporary directory for files being written and quickly deleted. As far as I can tell, the only difference is that it works even if there is no writable temporary directory. |
|
I was thinking more about a difference caused by using a stream vs. a random access file handle. (We've had similar issues with the PDF backend). But it seems that the postscript backend doesn't exhibit such problems. I think this is good to go. |
backend_ps: Do not write to a temporary file unless using an external distiller
3 participants
If
ps.usedistilleris omitted, writes directly to the output file, instead of creating a temporary file and subsequently copying it to the output.This is more efficient, and also works on restricted platforms such as Google App Engine, which are unable to provide a writable temporary file system.
Partial fix for Issue #1823.