Fix linting on v3.3.x#18102
Merged
Merged
Conversation
For certain reporters, it's necessary to do this filtering because GitHub does not allow posting to unrelated files. The github-check reporter _should_ allow it though, and we want to catch things like unused imports that may not be in the diff.
Since this is on a bugfix branch, don't remove the import in case it's in use. And fix a missing empty line.
timhoffm
reviewed
Jul 28, 2020
timhoffm
approved these changes
Jul 29, 2020
Member
|
CI failure Will be fixed by #18104. |
jkseppan
approved these changes
Jul 30, 2020
Member
jkseppan
left a comment
jkseppan
left a comment
There was a problem hiding this comment.
The code looks good to me but there are some Travis failures. I restarted the failing jobs, but I don't know if Travis will merge the current v3.3.x before running the tests. If not, perhaps this branch could be rebased on top of v3.3.x.
Member
|
The restarted Travis runs passed, so I think this is safe to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Backport of #18091, plus correction of flake8 error (see commits).
PR Checklist