I'm not entirely sure why it didn't complain in #17822, but I've disabled the filter entirely. For certain reporters, errors outside the diff would be a problem, but this does work with the one we are using. And we want to catch things that might be outside the diff, like imports no longer being used.

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout v3.3.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 560ccffce3200c6713e7d29beee6aaf382c53adc

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #18091: ci: Fix linting being ignored by reviewdog'

4. Push to a named branch :

git push YOURFORK v3.3.x:auto-backport-of-pr-18091-on-v3.3.x

5. Create a PR against branch v3.3.x, I would have named this PR:

"Backport PR #18091 on branch v3.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

I'm 50/50 on backporting the linting config to 3.3.x.

Since we never merge from 3.3.x to master, it might not be worth it. The branch has a life of what, 6-12 months?

We do merge up; I plan to do so after 3.3.1, as it fixes the git describe result.

Ah, ok. Then yes (as you've done)