Fix offset legend tightbbox#17511
Merged
tacaswell merged 2 commits intoMay 28, 2020
Merged
Conversation
jklymak
force-pushed
the
fix-offset-legend-tightbbox
branch
from
f3e92c8 to
a4922fe
Compare
Member
Author
|
This fixes pretty old bug marked as 3.3, so marking 3.3. But feel free to push forward to 3.4 |
QuLogic
reviewed
May 26, 2020
jklymak
force-pushed
the
fix-offset-legend-tightbbox
branch
from
a4922fe to
479036d
Compare
QuLogic
approved these changes
May 26, 2020
Member
|
It looks like a different test might have broken? |
Member
Author
|
Lots broke! I guess thats helpful, because I'm curious why... |
jklymak
force-pushed
the
fix-offset-legend-tightbbox
branch
from
479036d to
7adfd90
Compare
Member
Author
|
breakage was trivial: There was a test for the arguments legend was being called with, and since we are explicitly passing |
jklymak
force-pushed
the
fix-offset-legend-tightbbox
branch
from
7adfd90 to
b71691a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #10194
legend, if it receives a "None" for
bbox_transformpositions the legend relative to itsparent.bbox, which usually works fine, but if you mess with thetransFigure, as we do whenbbox_inches='tight'is called, then the new transFigure is not used (everything is still relative to the bbox of the figure, which doesn't change).This tiny change just sets a default transform for figure legends to be the figure's transform.
and adds a test...
PR Checklist