Make format_coord messagebox resize with the window and the content in osx backend#16710
Merged
Conversation
timhoffm
approved these changes
Mar 8, 2020
Member
timhoffm
left a comment
There was a problem hiding this comment.
Not an OSX programmer, but from the outside this looks reasonable. Maybe someone with OSX can test this?
Member
|
The only issue here is that the height over runs the toolbar if the window is very narrow |
Member
Contributor
Author
|
Thx. It occurred when the width of the toolbar is too small to hold the text. I have fixed this by limiting the maximum number of lines to 2. Now it shows perfectly at any width. |
tacaswell
approved these changes
Mar 10, 2020
Member
tacaswell
left a comment
There was a problem hiding this comment.
Also not an OSX programer, but the proof is in the pudding that this works.
jklymak
approved these changes
Mar 10, 2020
Member
|
Seems to be enough approvals to merge. Thanks @yuezhihan! |
5 tasks
|
Been waiting for this for over 2 years - thank you! (re: #10375) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR Summary
closes #16498
Example:
Before:


After:



PR Checklist