Convert named_colors example to use Rectangle#16467
Conversation
In line with #15614, this changes the named_colors example in the docs to use a Rectangle rather than drawing lines. This should make it more flexible to update in future.
Co-Authored-By: Tim Hoffmann <[email protected]>
|
Is the plan to open a new PR for the borders? |
|
Thanks, and congratulations on your first contribution to matplotlib! We'd love to see you back in the future. Note: I've squashed your commits before merging. We try to keep commits to logical units to keep the history more readable. You can use |
|
@timhoffm apologies - I just accepted through the GH interface, I'll push it through manually next time. @story645 there didn't seem to be a consensus as to whether we should change it or not, but it's a fairly trivial change I can make for a new PR if you feel like further discussion would be helpful? |
|
Yes, if you don't mind please make a new PR for the border. |
4 participants
Converts the named colours example to use
Rectanglerather thanhlinesfor ease of future updating. Discussions still ongoing in #15614 as to whether the colour swatches should be given borders or not.