UnCamelCase examples.#16201
Merged
Merged
Conversation
The changes in basic_units are possible because the unit framework now correctly handles unit subclasses, so we don't need to register dynamically created subclasses.
timhoffm
approved these changes
Jan 13, 2020
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
I was also unsure about the wx callback names. Does anybody know if there are common conventions for these?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in basic_units are possible because the unit framework now
correctly handles unit subclasses, so we don't need to register
dynamically created subclasses (since #13536).
Followup to https://github.com/matplotlib/matplotlib/pull/16199/files; I think the only remaining cases are callback names in wx examples.
PR Summary
PR Checklist