Deprecate Artist.{set,get}_contains.#16200
Merged
Merged
Conversation
timhoffm
approved these changes
Jan 14, 2020
anntzer
force-pushed
the
contains
branch
3 times, most recently
from
0886e70 to
5d7361b
Compare
Member
|
This appears to need a rebase to get working CI (failures don't appear to be related, I think), but also there are many references to these functions in |
I don't think it makes sense to allow overriding contains() checks per instance -- and if someone really need that, they can use a custom artist subclass or even just monkeypatch the contains method; if they need it for pick events there's still Artist.set_picker which is not going away. This came in in 8111a3a (2007) and was apparently never used or tested.
Contributor
Author
|
rebased. I think the references may as well stay until the whole thing is removed? |
Member
|
Actually, you removed them in #14960 (once it's merged.) |
Contributor
Author
|
then let's keep references removal that to that PR? |
QuLogic
approved these changes
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think it makes sense to allow overriding contains() checks
per instance -- and if someone really need that, they can use a custom
artist subclass or even just monkeypatch the contains method; if they
need it for pick events there's still Artist.set_picker which is not
going away.
This came in in 8111a3a (2007) and was apparently never used or tested.
PR Summary
PR Checklist