Fix tests with pandas 0.25#14858
Closed
dstansby wants to merge 1 commit into
Closed
Conversation
Member
|
#13304 explicitly deregistered the converters so we could test that our converters work on pandas objects. Are you saying our converters no longer work on pandas objects on 0.25? |
jklymak
requested changes
Jul 19, 2019
Member
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
blocking because I think we want to fix he root cause, not go back to registering pandas converters (unless we want to maintain them 😉)
Member
Author
|
Ah sorry, did not realise that. Yes, the reason the tests are failing now is because a pandas dtype isn't being converted properly any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From pandas 0.25 onwards the converters have to be explicitly registered or a warning is raised. I'm guessing they were never meant to be deregistered for the tests, so I've just changed that bit. Someone else may know better though?