Make unit converters also handle instances of subclasses.#13536
Merged
Conversation
anntzer
force-pushed
the
unit-subclasses
branch
from
b23af85 to
e756add
Compare
anntzer
force-pushed
the
unit-subclasses
branch
from
e756add to
6095dc2
Compare
Contributor
|
Would it be better to make the cache subclass dict and encapsulate the behavior there? |
Contributor
Author
|
It already subclasses dict and the "dict" interface is used for registering converters, which does not go through this logic; so keeping the entire get_converter logic in a separate method looks better to me. |
timhoffm
approved these changes
Mar 2, 2019
Contributor
|
Just ran into this bug in astropy and have created astropy/astropy#8818 to work around it by registering all subclasses of our |
Contributor
Author
|
rebased |
dstansby
approved these changes
Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #11275.
PR Checklist