Add method for comparing two colors#10032
Merged
Merged
Conversation
tacaswell
approved these changes
Dec 18, 2017
Member
|
Will need a what's new entry, won't it?
…On Mon, Dec 18, 2017 at 3:14 PM, Thomas A Caswell ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10032 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-NLFTC9rUD_jto6ZhCjiH5UsweUEks5tBseUgaJpZM4REpQf>
.
|
Member
|
👍 @WeatherGod sorry I missed that. |
efiring
approved these changes
Dec 18, 2017
Member
efiring
left a comment
efiring
left a comment
There was a problem hiding this comment.
Looks reasonable; I wonder where it would be used, apart from the legend?
Member
Author
|
There might be other bits of the codebase that compare if two colors are equal? Even if there aren't I think it's a useful user function to have given then many different ways colors can be specified, and it makes it clear in our internal code when we are comparing colors for equality. Will add a what's new when I get time, or if someone wants to push one to my branch feel free. |
Member
|
I think this is the first step towards a more consistent color representation at the python layer. |
Member
|
Right - see #9995. It would prob make sense to have a |
Member
|
Other thing to consider is how this would fold in with traitlets (don't
know where we currently stand on that.)
…On Mon, Dec 18, 2017 at 5:19 PM, Jody Klymak ***@***.***> wrote:
Right - see #9995 <#9995>.
It would prob make sense to have a color class that then did all this
automagically.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10032 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-I53v7kIeDIv4Lxsu4ZKnp1ns76Yks5tBuTYgaJpZM4REpQf>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colors in Matplotlib can come in many weird and wonderful forms; this allows two colors to be compared.