Repository navigation
add logic for calculating race winner - #1
Open
matissiyaEdu wants to merge 1 commit into
Open
matissiyaEdu wants to merge 1 commit into
matissiyaEdu wants to merge 1 commit into
Conversation
Comment on lines
+4
to
+5
| private final String name; | ||
| private final int speed; |
There was a problem hiding this comment.
Так как поля помечены final, то можно убрать геттеры и модификатор private
| public boolean equals(Object o) { | ||
| if (o == null || getClass() != o.getClass()) return false; | ||
| Car car = (Car) o; | ||
| return Objects.equals(getName(), car.getName()); |
There was a problem hiding this comment.
Ожидаемо, что помимо названия для сравнения объектов будет также использоваться скорость
| private static final int CARS_LIMIT = 3; | ||
|
|
||
| Scanner scanner = new Scanner(System.in); | ||
| Set<Car> cars = new HashSet<>(); |
There was a problem hiding this comment.
От хранения сета машин и лишнего цикла при определении победителя можно избавиться, если при вводе данных сразу вычислять победителя и хранить его в отдельной переменной, тогда программа будет требовать меньше памяти и работать быстрее
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.