Skip to content

Fix footnote renderer exception in markedjs - #2162

Merged
fxha merged 1 commit into
developfrom
fix-export-footnote
May 31, 2020
Merged

Fix footnote renderer exception in markedjs#2162
fxha merged 1 commit into
developfrom
fix-export-footnote

Conversation

@fxha

@fxha fxha commented May 30, 2020

Copy link
Copy Markdown
Contributor
Q A
Bug fix? yes
License MIT

Description

This PR fixes two issue when exporting documents:

  • Fixed a crash in markedjs because footnoteIdentifier function was not implemented for inline renderer.
  • Fixed issue that the footnote link reference was wrong.

@fxha
fxha requested a review from Jocs May 30, 2020 19:03
@fxha
fxha merged commit 79c7200 into develop May 31, 2020
@fxha
fxha deleted the fix-export-footnote branch May 31, 2020 21:21
Jocs added a commit that referenced this pull request Jul 16, 2021
* update readme (#2008)

* update readme

* remove unused codes

* Update third party

* remove unused codes

* fix: style error in editor setting

* Release v0.16.1 (#2011)

* Fix typo (#2118)

* Include Chocolatey package installation option (#2107)

* Update dependencies (#2133)

* Fix max width of editor tabs (#2097)

* Fix max width of editor tabs

* Update sponsor (#2141)

* update: sponsors

* update img width and height

* Add ability to paste images to Features (#2127)

* Fix empty shortcuts in shortcut validator (#2130)

* Fix Hunspell dictionary downloader on Windows (#2131)

* Add missing encoding entry (#2132)

* Improve heading font size scaling (#2135)

* Reduce dependency bundle size (#2136)

* Fix Hunspell spell checker initialization on Windows (#2137)

* Disable and hide unnecessary settings options (#2138)

* Increase indentation for sidebar treeview (#2161)

* Fix image export issues on Windows (#2129)

* Fix footnote renderer exception in markedjs (#2162)

* Add GitLab math block support (#2119)

* update: yarn.lock file (#2178)

* feat: switch tabs using alt-#num (#1975)

* Fix bad font when exporting document on macOS (#2190)

* 📝 update zh_cn.md (#2192)

* Improve English grammar in user-interface text. (#2075)

* Fix unnecessary character sanitation on clipboard output (#2197)

* Fix double used shortcut (#2198)

* Fix double used shortcut

* Update documentation

* Update dependencies (#2199)

* Support setting text direction via comand palette (#2194) (#2195)

* Update bug issue template (#2215)

* Fix inline html renderer (#2224)

* Fix sub- and superscript in HTML output

* Update dependencies

* Conform user-interface text to conventions for trailing punctuation (#2209)

* Release v0.16.2 (#2200)

Bump version to 0.16.2 and update documentation.

* Replace PRC emoji for zh_TW translation with Taiwan flag (#2278)

* Update FAQ.md (#2290)

Clarify what aidou is for non-chinese users

* Fix markdown syntax document mistake for table content align (#2282) (#2296)

* Update pt.md (#2350)

* Update pt.md

My annual contribution to Mark Text, with its documentation accessible to all Brazilians and Portuguese.

* Update pt.md

* Update pt.md

* Update pt.md

* Update pt.md

* Update pt.md

* Update pt.md

* Update pt.md

* Update pt.md

* Update regex of auto link to fix trailing slashes (#2354)

* Update FAQ.md - link to Portable (#2337)

Fixing link to portable page.

* updated turkish translation of readme.md (#2366)

* pass file.id to closeTab on middle click (#2272)

* Add codeblock highlight and coloration for the SPARQL and Turtle languages (#2365)

* fix image paths on readme tr.md (#2374)

* Fix issue with not being able to copy table cell (#2375)

* fixed issue#2383 (#2397)

* Fix quick open bug and freeze constants to avoid accidental mutation (#2323)

* fix: #2330 enable shift+tab for table navigation (#2331)

* fix: prism language missing while load dependent language (#1752) (#2335)

* Fix graphite light wordcount (#2392)

* Update dependencies (minor only) (#2402)

* fix: typewriter shake after press enter (#1852)

* Support negative zoom (#2412)

* Restrict export dialog file extensions (#2408)

* Allow BCP-47 language codes in spell checker (#2410)

* Fix footnote inline code font size (#2411)

* feat: add shortcut for toggle-toc (#1863) (#2326)

* Make global menu fields mutable (#2407)

* Replace text when only one table cell is selected (#2413)

* Allow to copy table cells text as plaintext (#2409)

* Fix font selection autocomplete (#2420)

* Updated korean translation of README.md (#2432)

I updated ko.md (korean translation of README.md) to match the latest version of README.md

* Rebase markedjs bug fixes (#2419)

* Add option to disable HTML rendering (#2414)

* Fix symbolic links and related path issues (#2416)

* Upgrade to N-API and Electron 11 (#2422)

* Upgrade to N-API and Electron 11

* Update Electron and remove workaround

* Fix ESLint error

* Disble MathML due to DOMPurify security issues (#2436)

* Update Simplified Chinese translation of README (#2445)

* Improve undo history (#2437)

* Add TOC generator to document exporter (#2391)

* Add support for relative image directory (#2439)

* Fix installation instructions in README.md (#2449)

* Update README.md

Calling brew cask install is disabled

* Update i18n files

* Release v0.16.3 (#2448)

Co-authored-by: Ran Luo <[email protected]>
Co-authored-by: saymoon <[email protected]>
Co-authored-by: shaunmbg <[email protected]>
Co-authored-by: Micael Dias <[email protected]>
Co-authored-by: Dan Dascalescu <[email protected]>
Co-authored-by: BeatLink <[email protected]>
Co-authored-by: He Linming <[email protected]>
Co-authored-by: Royce <[email protected]>
Co-authored-by: brainchild0 <[email protected]>
Co-authored-by: Rasmus Eneman <[email protected]>
Co-authored-by: nyanpasu64 <[email protected]>
Co-authored-by: Sbelletier <[email protected]>
Co-authored-by: 小新 <[email protected]>
Co-authored-by: Enderson Menezes <[email protected]>
Co-authored-by: Sweet Liquid <[email protected]>
Co-authored-by: Nick Ali <[email protected]>
Co-authored-by: erentar <[email protected]>
Co-authored-by: Max Lantas <[email protected]>
Co-authored-by: Vincent Emonet <[email protected]>
Co-authored-by: Amauri Bizerra <[email protected]>
Co-authored-by: Anton Freeman <[email protected]>
Co-authored-by: Dan Munckton <[email protected]>
Co-authored-by: evan-cohen <[email protected]>
Co-authored-by: zmen <[email protected]>
Co-authored-by: bmvisoky <[email protected]>
Co-authored-by: YeloMelon <[email protected]>
Co-authored-by: MingZZX <[email protected]>
Co-authored-by: カワリミ人形 <[email protected]>
thimbleberrysystems pushed a commit to thimbleberrysystems/WordBird that referenced this pull request Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants