Skip to content

Fix mermaid diagram is not visiable when export html - #1732

Merged
Jocs merged 2 commits into
developfrom
fix-export-mermaid
Nov 22, 2019
Merged

Fix mermaid diagram is not visiable when export html#1732
Jocs merged 2 commits into
developfrom
fix-export-mermaid

Conversation

@Jocs

@Jocs Jocs commented Nov 21, 2019

Copy link
Copy Markdown
Member
Q A
Bug fix? yes
Fixed tickets #1670
License MIT

Description

[Description of the bug or feature]

--

Please, don't submit /dist files with your PR!


This change is Reviewable

@Jocs
Jocs requested a review from fxha November 21, 2019 05:40

@fxha fxha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will show the document twice if you export a document. Please try this document with your change and you will notice that the exported HTML (.ag-render-container container) is visible while exporting. That's was the reason to hide the container.

@Jocs

Jocs commented Nov 21, 2019

Copy link
Copy Markdown
Member Author

That's was the reason to hide the container.

Hide this container will cause render mermaid\flowchart incorrectly. So we need to put it out of viewport(off screen).

@Jocs
Jocs requested a review from fxha November 21, 2019 14:34
@Jocs
Jocs merged commit fc15356 into develop Nov 22, 2019
@Jocs
Jocs deleted the fix-export-mermaid branch November 22, 2019 11:01
@fxha

fxha commented Nov 28, 2019

Copy link
Copy Markdown
Contributor

@Jocs The content is visible again during export on latest develop/v0.16.0-rc2. E.g. export a document with multiple paragraphs and some math formulas.

@Jocs

Jocs commented Dec 2, 2019

Copy link
Copy Markdown
Member Author

Maybe we can only use z-index to make the rendered printed page appear below the editor.

thimbleberrysystems pushed a commit to thimbleberrysystems/WordBird that referenced this pull request Jun 21, 2026
* Fix mermaid diagram is not visiable when export html

* make the print render container off screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants