Skip to content

Add Windows spell checker and fixes - #1624

Merged
fxha merged 3 commits into
developfrom
windows-spellchecker
Nov 7, 2019
Merged

Add Windows spell checker and fixes#1624
fxha merged 3 commits into
developfrom
windows-spellchecker

Conversation

@fxha

@fxha fxha commented Nov 6, 2019

Copy link
Copy Markdown
Contributor
Q A
Bug fix? yes
New feature? yes
License MIT

Description

  • Add support for native Windows 10 spellchecker.
  • Fix bug that Hunspell cannot be used on macOS and Windows 10 due to some strange Webpack (?) behavior - added workaround for this.
  • Some small fixes and improvements.

Changes:

@fxha
fxha requested a review from Jocs November 6, 2019 14:52
@Jocs

Jocs commented Nov 6, 2019

Copy link
Copy Markdown
Member

@fxha I tested, and both Hunspell and macOS spell check works well.

@fxha fxha changed the title [DO NOT MERGE] Add Windows spell checker and fixes Add Windows spell checker and fixes Nov 6, 2019
Comment thread src/index.ejs
@fxha
fxha merged commit 3eb2f3b into develop Nov 7, 2019
@fxha
fxha deleted the windows-spellchecker branch November 7, 2019 15:55
Jocs pushed a commit that referenced this pull request Nov 7, 2019
* Add Windows spell checker and fixes

* Fix build failure on macOS

* Fix preference visibility
fxha added a commit that referenced this pull request Nov 8, 2019
* Fix allowed paragraph transformations

* Fix wrong condition

* Add Windows spell checker and fixes (#1624)

* Add Windows spell checker and fixes

* Fix build failure on macOS

* Fix preference visibility

* Bump version to v0.16.0-rc1

* Update Electron
thimbleberrysystems pushed a commit to thimbleberrysystems/WordBird that referenced this pull request Jun 21, 2026
* Add Windows spell checker and fixes

* Fix build failure on macOS

* Fix preference visibility
thimbleberrysystems pushed a commit to thimbleberrysystems/WordBird that referenced this pull request Jun 21, 2026
* Fix allowed paragraph transformations

* Fix wrong condition

* Add Windows spell checker and fixes (marktext#1624)

* Add Windows spell checker and fixes

* Fix build failure on macOS

* Fix preference visibility

* Bump version to v0.16.0-rc1

* Update Electron
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants