Skip to content

1420 gradle incremental - #1971

Merged
filiphr merged 5 commits into
mapstruct:masterfrom
ttzn:1420-gradle-incremental
Dec 8, 2019
Merged

1420 gradle incremental#1971
filiphr merged 5 commits into
mapstruct:masterfrom
ttzn:1420-gradle-incremental

Conversation

@ttzn

@ttzn ttzn commented Nov 17, 2019

Copy link
Copy Markdown
Contributor

As discussed in #1420, this PR makes Mapstruct compatible with Gradle's incremental annotation processing feature. The actual change is just one file with a single line of configuration; the bulk of this contribution is in the integration tests, written using the Gradle TestKit.

ttzn added 4 commits November 17, 2019 18:09
* add relevant file in META-INF
* add integration test and Gradle test kit dependencies

TODO: maybe use file timestamps instead of relying on Gradle --info output
* add several test cases
* test sources actually have something to map
* parameterize tests with major Gradle versions
* remove printlns
* align root directory with default working directory of CI build
* mapstruct_root property
* license headers and style fixes

@sjaakd sjaakd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. But I don't have that much Gradle knowledge.. @filiphr : WDYT?

@filiphr

filiphr commented Dec 8, 2019

Copy link
Copy Markdown
Member

Thanks a lot for the PR @ttzn looks really great.

Can you please share your name so we can add it to our copyright.txt?

@ttzn

ttzn commented Dec 8, 2019

Copy link
Copy Markdown
Contributor Author

Glad to help @filiphr. I added my name in the file. Do you need me to squash the commits ?

@filiphr
filiphr merged commit 779eb1b into mapstruct:master Dec 8, 2019
@filiphr

filiphr commented Dec 8, 2019

Copy link
Copy Markdown
Member

Thanks a lot @ttzn, I just squashed the commits and merged the PR.

@nisrulz

nisrulz commented Dec 10, 2019

Copy link
Copy Markdown

Hi,

First of all thank you for all the work done by you and everyone involved 👏

I was reading through the PR and I see it is merged. I was wondering when can a new release be expected that includes this incremental functionality? I am interested in this feature, thus was following this PR.

Additionally, is there anything I can do to help getting a new release out?

Thank you

@ttzn

ttzn commented Dec 15, 2019

Copy link
Copy Markdown
Contributor Author

I second this. I would like to know when we can expect this feature to be part of a release. I'm ready to write relevant documentation or whatever it takes to speed things up, if you can point me in the right direction.

@nisrulz

nisrulz commented Jan 3, 2020

Copy link
Copy Markdown

Any updates?

@sjaakd

sjaakd commented Jan 5, 2020

Copy link
Copy Markdown
Contributor

Any updates?

merged and waiting for next release

@nisrulz

nisrulz commented Jan 5, 2020

Copy link
Copy Markdown

Yes @sjaakd I understand that part. My question was regarding the release timeline?

The last release was made in Sept,2019.

Screen Shot 2020-01-05 at 1 05 00 PM

Sorry if my last comment was not clear. Is there a timeline to which the releases adhere too?

Maybe there is a blocker issue which is keeping from making the release that I am unaware of?

I would like to help in getting a release out asap just so that I can leverage the incremental build functionality. Not having it is acting as a bottle neck for productivity for a lot of people in my team. We moved all the dependencies to incremental kapt, but are waiting on only this one now.

@sjaakd

sjaakd commented Jan 5, 2020

Copy link
Copy Markdown
Contributor

Sorry if my last comment was not clear. Is there a timeline to which the releases adhere too?

I guess we want one or two major features in.. Like the map-to-object which I'm working on.. Also the switching / on / off of mapping methods..

@mformetal

Copy link
Copy Markdown

There any updates on when that major release will be?

@banderous

banderous commented Apr 19, 2020

Copy link
Copy Markdown

Any chance of getting this released? This could transform productivity in a number of our projects, the difference incremental compilation makes for us is huge.

@filiphr

filiphr commented Apr 19, 2020

Copy link
Copy Markdown
Member

We are getting closer and closer to releasing an initial Beta for 1.4. I just created #2074 which I want to be part of the next release. Once that is in we would be able to to a release quite fast. Thanks for the patience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants