upgrade requestretry - #52
Merged
Merged
Conversation
added 2 commits
July 11, 2017 18:05
jakepruitt
reviewed
Jul 15, 2017
| tilejson.getTile(2, 2, 2, function(err, data, headers) { | ||
| assert.equal(err.code, 'ECONNRESET'); | ||
| assert.equal(connectionCount, 2); | ||
| assert.equal(connectionCount, 1); |
There was a problem hiding this comment.
I think we'll want to leave the 2 here and change the maxAttempts here https://github.com/mapbox/node-tilejson/blob/master/lib/tilejson.js#L219 to 2, since it looks like maxAttempts setting was a lie until this change in requestretry: FGRibreau/node-request-retry@a130355.
Contributor
Author
There was a problem hiding this comment.
Nice catch, thanks for digging!
| tilejson.getTile(1, 0, 0, function(err, data, headers) { | ||
| assert.ok(err); | ||
| assert.equal(err.message, 'ETIMEDOUT'); | ||
| assert.equal(err.message, 'ESOCKETTIMEDOUT'); |
There was a problem hiding this comment.
I think this change in error code is fine - it still timed out either way, which is what we want to see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated tests to reflect changes that came along with this upgrade. Will definitely need another set of 👀, this doesn't seem like expected behavior to me.