Slack client v2 development#394
Merged
Merged
Conversation
This was referenced Mar 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
===========================================
- Coverage 76.55% 56.96% -19.59%
===========================================
Files 10 6 -4
Lines 418 732 +314
Branches 75 42 -33
===========================================
+ Hits 320 417 +97
- Misses 87 306 +219
+ Partials 11 9 -2
Continue to review full report at Codecov.
|
added 18 commits
April 7, 2019 22:33
…e.py file to include the correct import (#397)
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
===========================================
- Coverage 76.55% 56.96% -19.59%
===========================================
Files 10 6 -4
Lines 418 732 +314
Branches 75 42 -33
===========================================
+ Hits 320 417 +97
- Misses 87 306 +219
+ Partials 11 9 -2
Continue to review full report at Codecov.
|
c-goosen
pushed a commit
to c-goosen/python-slackclient
that referenced
this pull request
Jun 18, 2019
This PR implements the changes specified in RFC slackapi#384. However, the most notable deviation is that we've decided that v2 will target Python 3.6+ only! Python 2.7+ will continue to be supported in v1 until Dec 31st, 2019. See additional details in slackapi#384!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a WIP. It implements most of the changes specified in #384. However, the most notable deviation is that we've decided that v2 will target Python 3.6+ only! Python 2.7+ will continue to be supported in v1 until Dec 31st, 2019. See additional details in #384!
Still in development:
Requirements