Skip to content

Add integration attributes to sdk#26

Merged
alexs-mparticle merged 2 commits into
mParticle:masterfrom
v-mamaya:integration-attributes
Jun 20, 2023
Merged

Add integration attributes to sdk#26
alexs-mparticle merged 2 commits into
mParticle:masterfrom
v-mamaya:integration-attributes

Conversation

@v-mamaya
Copy link
Copy Markdown
Contributor

Summary

Added support for integration attributes in case they are needed to be included using the Python SDK

Testing Plan

  • Was this tested locally?
  • I tested using unit tests, by asigning a dictionary with the proper structure to the batch object and checking the resulting output when it is assigned
  • I've sent some batches via Custom Feed using the Python SDK and verified the proper integration attributes appear on the batch in Livestream

@v-mamaya v-mamaya marked this pull request as ready for review June 15, 2023 18:25
@v-mamaya
Copy link
Copy Markdown
Contributor Author

hey @alexs-mparticle, can you take a look and let me know if we should change something?

Copy link
Copy Markdown
Contributor

@alexs-mparticle alexs-mparticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only one style issue. I can release this once the change is made.

Comment thread example_usage.py Outdated
@v-mamaya v-mamaya requested a review from alexs-mparticle June 20, 2023 14:23
@alexs-mparticle alexs-mparticle merged commit 6772fc2 into mParticle:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants