Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PopsIDX
force-pushed
the
refactor-editor
branch
from
August 26, 2026 07:07
3005450 to
8a13d4c
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What is this PR ?
With our current editor (Ace), we have a hard time customizing the style and matching what we want to do with the mode. Bending the Ace css to our will is hard and tricky.
This is why I changed the editor from Ace to CodeMirror! What is nice with this rich editor is that we have more ways to customize it, from the extensions used to the css used inside the editor.
This is a first PR to migrate the editor, and then we will be able to do another PR for updating and adding more CSS!
⚙️ How does it work ?
EditorView.tsxuseCodeMirrorhook because it should not be the responsability of the EditorView.🧪 How to test
If you want a code example, I used this bit for my tests :