updated sampling - #5
Merged
Merged
Conversation
Changed the parameter assignment via dictionaries such that the mixture coefficients are not NaN after setting non-mixture parameters only.
when mixture parameters are set to zero the log likelihood is -inf. the multiplication with the latent variables (which are zero in that case) equals to nan instead of zero. Two minor changes have been made to catch that case and prevent the warnings such that the log isnt full of warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated the sampling such that:
The full IP algorithm is not used, as the sampling takes too long. Thus this algorithm can be discarded in the future.