Skip to content

Fix NRE when VS is not installed. #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 1 commit into from
Jan 2, 2019
+3 −3
Merged

Fix NRE when VS is not installed. #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions SharpGen/Parser/SdkResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@ private string GetVSInstallPath()
do
{
enumInstances.Next(1, instances, out fetched);
var instance2 = (ISetupInstance2)instances[0];
var state = instance2.GetState();
if (fetched > 0)
{
var instance2 = (ISetupInstance2)instances[0];
var state = instance2.GetState();
if ((state & InstanceState.Registered) == InstanceState.Registered)
{
if (instance2.GetPackages().Any(pkg => pkg.GetId() == "Microsoft.VisualStudio.Component.VC.Tools.x86.x64"))
Expand All @@ -79,7 +79,7 @@ private string GetVSInstallPath()
}
while (fetched > 0);

Logger.Fatal("Unable to find compatible Visual Studio installation path.");
Logger.Fatal("Unable to find a Visual Studio installation that has the Visual C++ Toolchain installed.");

return null;
}
Expand Down