Skip to content

Add Handling For Access Tokens That Never Expire (ex: GITHUB) - #491

Merged
FalkWolsky merged 1 commit into
devfrom
fix-github-oauth-bug
Nov 10, 2023
Merged

FalkWolsky merged 1 commit into
devfrom
fix-github-oauth-bug

Conversation

@aq-ikhwa-tech

@aq-ikhwa-tech aq-ikhwa-tech commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

  • Added handling to allow tokens that never expire to be saved properly in db

Github Docs Link: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/token-expiration-and-revocation
Stackoverflow Link: https://stackoverflow.com/questions/26902600/whats-the-lifetime-of-github-oauth-api-access-token

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@netlify

netlify Bot commented Nov 10, 2023

Copy link
Copy Markdown

Deploy Preview for lowcoder-test canceled.

Name Link
🔨 Latest commit 9d5da85
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/654e95e3881ad80008efd609

@FalkWolsky FalkWolsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this important Fix!

@FalkWolsky
FalkWolsky merged commit 03298e5 into dev Nov 10, 2023
@FalkWolsky
FalkWolsky deleted the fix-github-oauth-bug branch November 10, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants