Skip to content

Fix Condition For For Respecting Enable Sign Up Flag - #429

Merged
FalkWolsky merged 1 commit into
devfrom
fix-for-enable-sign-up-var
Oct 22, 2023
Merged

FalkWolsky merged 1 commit into
devfrom
fix-for-enable-sign-up-var

Conversation

@aq-ikhwa-tech

@aq-ikhwa-tech aq-ikhwa-tech commented Oct 22, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

  • Corrected the conditioning to reflect the following cases:
Admin Exists SignUp Var Sign Up Button
F F T
F T T
T F F
T T T

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@netlify

netlify Bot commented Oct 22, 2023

Copy link
Copy Markdown

Deploy Preview for lowcoder-cloud canceled.

Name Link
🔨 Latest commit b42a731
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-cloud/deploys/6534bad1eb57f10008533aab

@aq-ikhwa-tech
aq-ikhwa-tech changed the base branch from main to dev October 22, 2023 06:02

@FalkWolsky FalkWolsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the Hotfix!

@FalkWolsky
FalkWolsky merged commit af78da6 into dev Oct 22, 2023
@FalkWolsky
FalkWolsky deleted the fix-for-enable-sign-up-var branch October 22, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants