Repository navigation
fix(desktop): fence stale update status responses - #5693
Merged
huangruiteng merged 1 commit intoOct 5, 2026
Merged
huangruiteng merged 1 commit into
huangruiteng merged 1 commit into
Conversation
Signed-off-by: Duang777 <[email protected]>
Duang777
requested review from
huangruiteng,
loopx-agent and
maxliux5
as code owners
October 5, 2026 14:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
desktop_update_statuscould capture state before bounded diagnostics, while both desktop frontends accepted delayed polling responses after a newer update action completed.downloadingresponse previously replacedrestart_requiredand could expose Apply again; the same deterministic browser scenario now keeps Restart visible and records exactly one Apply request.main.Author Declaration
Implemented against
desktop_update_statusinmaintenance.rsboot.js,desktop-update.tsxdesktop-update-browser-smoke.mjsupstream/main, checked DCO, public/private boundaries, formatting, static analysis, unit tests, production frontend bundles, exact runtime bundle generation, and the browser journey. A signed packaged App was deliberately not built because release signing fixtures are unavailable.Scope And Continuation
Validation
647188f74eb961731a6dcc0f502b3e0379d10d26regression_paritypassedc46f397c0and passes on this revision for workspace and boot entry points.real_entrypointpassedunitpassedstaticpassedintegrationpassedstaticpassed.appwas installed or exercised. The deterministic IPC double covers response ordering, while Rust tests compile and execute the backend with the exact generated runtime resources.Frontend / Visual Evidence
Type of Change
LoopX Area
Technical Direction
Shared-authority RFC fixture impact
N/A. This change does not claim progress against the TypeScript control-plane migration or shared Goal Authority RFC.
Boundary Checklist
none.Signed-off-bytrailer (git commit -s).