Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

mm: support python3.9#5640

Closed
matt-mercer wants to merge 1 commit into
localstack:masterfrom
matt-mercer:mm-python-3-9
Closed

mm: support python3.9#5640
matt-mercer wants to merge 1 commit into
localstack:masterfrom
matt-mercer:mm-python-3-9

Conversation

@matt-mercer
Copy link
Copy Markdown
Contributor

Please refer to the contribution guidelines in the README when submitting PRs.

@dfangl
Copy link
Copy Markdown
Member

dfangl commented Mar 9, 2022

Hi Matt! Thanks for your PR. However, this is potentially superseded by #5632.
You also did some work in the Dockerfile as I see, could you elaborate why you deem them necessary?

@matt-mercer
Copy link
Copy Markdown
Contributor Author

matt-mercer commented Mar 9, 2022

@dfangl

Hi Matt! Thanks for your PR. However, this is potentially superseded by #5632. You also did some work in the Dockerfile as I see, could you elaborate why you deem them necessary?

Ah hi .. great that python 3.10 is in flight .. I'll close and wait on that, feel I would be fighting circleci for some time yet with this,
In terms of the non python3.9 dockerfile changes, tbh, I'm just in the habit of compacting RUN commands to reduce the layers / image size otherwise hadolint tells me off ;)

@matt-mercer matt-mercer closed this Mar 9, 2022
@dfangl
Copy link
Copy Markdown
Member

dfangl commented May 3, 2022

Hi there @matt-mercer ! Just wanted to let you know python 3.10 support is now merged!

@matt-mercer matt-mercer deleted the mm-python-3-9 branch June 6, 2022 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants