This repository was archived by the owner on Mar 23, 2026. It is now read-only.
remove pins in setup.cfg, add .python-version#10195
Merged
Merged
Conversation
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 23s ⏱️ Results for commit eb99701. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 22m 10s ⏱️ - 3m 6s For more details on these failures, see this check. Results for commit eb99701. ± Comparison against base commit 361abbf. ♻️ This comment has been updated with latest results. |
silv-io
reviewed
Feb 8, 2024
24a52ea to
6105fed
Compare
silv-io
approved these changes
Feb 8, 2024
Member
silv-io
left a comment
There was a problem hiding this comment.
LGTM! Just a small thought and question
MEPalma
reviewed
Feb 8, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#10127 introduced dependency pinning.
This is a good opportunity to revisit current pins in the
setup.cfgand try to upgrade as much as possible, as well as to remove some safety pins which have just defined to avoid breaking changes in the future (which is not necessary, because this only happens in a dedicated PR now).Changes
setup.cfgas possible and updates the pins.moto-ext- explicitly updated when we create a release of ourmotoforkdill- iirc this should be pinned to avoid a breaking change? /cc @giogranobotocore- explicitly updated with ASF updates, see pin botocore with ASF API updates, add ASF API forward compatibility #10183docker- waiting for a release of 7.0: Docker Tag Parsing Issue with Registry Ports docker/docker-py#3195 / fix: tag regex should allow ports docker/docker-py#3196black- limited to the major version 23 to avoid lots of reformatting, should be upgraded separately or replaced withruff formatjsonpath-ng- has been pinned with Pin jsonpath_ng to 1.5.3 to unblock CI #9142, breaks skip verification handling in snapshot library (test_dot_in_skip_verification_path) /cc @dominikschubertantlr4-python3-runtime- the antlr4 runtime is tightly coupled to the generated code. The pin will remain for now, and once the generation is automated, we can automate version upgrades. See remove pins in setup.cfg, add .python-version #10195 (comment)..python-versionfile.TODO