Skip to content

Github action - #179

Merged
ShariqT merged 1 commit into
masterfrom
gh-actions
Dec 29, 2021
Merged

Github action#179
ShariqT merged 1 commit into
masterfrom
gh-actions

Conversation

@Kilo59

@Kilo59 Kilo59 commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

TODO

  • Add API key secret
  • Fix tests
  • verify coveralls step
  • add pypy to test matrix
  • remove travis file

@Kilo59 Kilo59 self-assigned this Dec 10, 2021
@Kilo59

Kilo59 commented Dec 17, 2021

Copy link
Copy Markdown
Contributor Author

@ShariqT
ShariqT force-pushed the gh-actions branch 2 times, most recently from 2d7031c to 755d310 Compare December 20, 2021 23:39
@ShariqT

ShariqT commented Dec 20, 2021

Copy link
Copy Markdown
Contributor

The coveralls step will take a little more investigation. The Coverall Github Action only takes lcov.info files, but coverage doesn't output anything but json, html or xml. I tried some of the suggestions found in this issue. In the meantime, we can at least have the tests running and circle back in the new year about what to do with coveralls. In the thread there were people suggesting other services that will parse json and xml, so that is something else to consider.

@ShariqT
ShariqT marked this pull request as ready for review December 20, 2021 23:55
Comment thread Pipfile Outdated
@@ -0,0 +1,23 @@
name: Pipenv Coveralls Test

on: ["push", "pull_request"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this push intentional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a public repo so I don't think the minutes eaten up by it cost Lob anything.

@ShariqT
ShariqT merged commit 9382ba6 into master Dec 29, 2021
@ShariqT
ShariqT deleted the gh-actions branch December 29, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants