add identity validation, del Campaigns APIs - #275
Merged
Conversation
jho44
force-pushed
the
identityValidation
branch
from
August 24, 2022 23:28
8152747 to
14f1330
Compare
Comment on lines
+56
to
+58
| apiClient.setBasePath(BASE_PATH); | ||
| basicAuth.setUsername(LOB_API_KEY); | ||
| return apiClient; |
Contributor
Contributor
Author
There was a problem hiding this comment.
One of the functions uses the TEST KEY for integration tests while the other (previously undefined) uses the LIVE KEY for integration tests. I was following precedent with older SDK tests. But in hindsight, it would've been DRYer to pass "live" or "test" as a parameter to one function that chooses between the keys based on the parameter. Should I do that instead? I'll need to edit all other files that use the getConfigForIntegration function.
Contributor
There was a problem hiding this comment.
@jho44 Nope it's ok it must be the weird layout in GH, it looked like they were doing the exact same thing. This is fine the way it is. Thanks!
BennyKitchell
approved these changes
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticket
Added Identity Validation API and tests
Regen SDK
Deleted Campaign APIs