Skip to content

CDATA support for RSS description was added #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
woxcab wants to merge 1 commit into from
Closed

CDATA support for RSS description was added #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions feedgen/entry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,15 @@ def rss_entry(self, extensions=True):
link.text = self.__rss_link
if self.__rss_description and self.__rss_content:
description = etree.SubElement(entry, 'description')
description.text = self.__rss_description
description.text = self.__rss_description['content']
content = etree.SubElement(entry, '{%s}encoded' %
'http://purl.org/rss/1.0/modules/content/')
content.text = etree.CDATA(self.__rss_content['content']) \
if self.__rss_content.get('type', '') == 'CDATA' else self.__rss_content['content']
elif self.__rss_description:
description = etree.SubElement(entry, 'description')
description.text = self.__rss_description
description.text = etree.CDATA(self.__rss_description['content']) \
if self.__rss_description.get('type', '') == 'CDATA' else self.__rss_description['content']
elif self.__rss_content:
description = etree.SubElement(entry, 'description')
description.text = self.__rss_content['content']
Expand Down Expand Up @@ -442,28 +443,31 @@ def summary(self, summary=None):
# Replace the RSS description with the summary if it was the summary
# before. Not if is the description.
if not self.__rss_description or \
self.__rss_description == self.__atom_summary:
self.__rss_description = summary
self.__rss_description['content'] == self.__atom_summary:
self.__rss_description['content'] = summary
self.__atom_summary = summary
return self.__atom_summary


def description(self, description=None, isSummary=False):
def description(self, description=None, isSummary=False, type=None):
'''Get or set the description value which is the item synopsis.
Description is an RSS only element. For ATOM feeds it is split in summary
and content. The isSummary parameter can be used to control which ATOM
value is set when setting description.

:param description: Description of the entry.
:param isSummary: If the description should be used as content or summary.
:param type: If type is CDATA content would not be escaped.
:returns: The entries description.
'''
if not description is None:
self.__rss_description = description
self.__rss_description = {'content': description}
if isSummary:
self.__atom_summary = description
else:
self.__atom_content = description
if type is not None:
self.__rss_description['type'] = type
return self.__rss_description


Expand Down