Support touch events#16
Merged
gabrielhase merged 2 commits intomasterfrom Jan 6, 2021
Merged
Conversation
peyerluk
reviewed
Jan 6, 2021
peyerluk
approved these changes
Jan 6, 2021
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, the crop controls did only work for desktop devices, not for mobile, i.e. touch devices.
With this change, the cropping can also be performed from a mobile device.
Changelog
touchstart,touchmoveandtouchendevents next to the equivalent mouse events (since we use namespaces on the events, it is necessary to explicitly declare the touch events)pageXandpageYfor both mobile and desktop cases