Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 22097 ]] Docs: effective rect of stack docs should mention need for the stack to have been opened - #7110

Merged
livecodepanos merged 3 commits into
livecode:developfrom
researchware:patch-2
Jun 27, 2019
Merged

[[ Bug 22097 ]] Docs: effective rect of stack docs should mention need for the stack to have been opened#7110
livecodepanos merged 3 commits into
livecode:developfrom
researchware:patch-2

Conversation

@researchware

Copy link
Copy Markdown
Contributor

No description provided.

@livecodepanos

Copy link
Copy Markdown
Contributor

Thanks @researchware for the PR.

Could you also add a bugfix note, as described in the first comment in #7109?

Also, this is fine for this PR, but for future reference, the base for community PRs that include dictionary updates should be branch develop-9.0. This means the change will appear in LC 9.0.x, and then we will merge develop-9.0 into develop, so as the change appears in LC 9.5.x as well.

So in the future, you have to create your branch (that will include the change) from develop-9.0, and submit the PR against develop-9.0 - as you did with this PR: #7109

@livecodepanos

Copy link
Copy Markdown
Contributor

@researchware I have edited the release note -for future reference the first letter should be uppercase.

Thank you for the PR

@livecode-vulcan review ok fb788a4

@livecode-vulcan

Copy link
Copy Markdown
Contributor

💙 review by @livecodepanos ok fb788a4

livecode-vulcan added a commit that referenced this pull request Jun 27, 2019
[[ Bug 22097 ]]  Docs: effective rect of stack docs should mention need for the stack to have been opened
@livecode-vulcan

Copy link
Copy Markdown
Contributor

😎 test success fb788a4

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-ndk16r15: success
  • try-community-arm64-android-ndk16r15: success
  • try-community-x86-android-ndk16r15: success
  • try-community-x86_64-android-ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos12.1: success
  • try-community-universal-ios-iphonesimulator12.1: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos added this to the 9.5.0-dp-2 milestone Jun 27, 2019
@livecodepanos
livecodepanos merged commit 73b8474 into livecode:develop Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants