This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Prebuilt ]] Build Linux prebuilt libraries with position-independant code - #6953
Merged
Conversation
…aries By building the prebuilt libraries with position-independent code, we enable them to be linked into position-independent executables, which is now the default for executables built with recent versions of GCC (v6 onwards)
…ision Make sure the Curl build script generates the correct archive name for OpenSSL with a non-empty buildrevision, otherwise the build will fail.
Contributor
|
@livecode-vulcan review ok 17637ac |
Contributor
|
💙 review by @runrevmark ok 17637ac |
livecode-vulcan
added a commit
that referenced
this pull request
Apr 17, 2019
…-pic [[ Prebuilt ]] Build Linux prebuilt libraries with position-independant code This patch enables the `-fPIC` option when compiling Linux prebuilt libraries, allowing those libraries to be used to create position-independent executables, which is now the default in the version of GCC provided with Ubuntu 18.04.
Contributor
|
😞 test failure 17637ac
|
Member
|
@livecode-vulcan retry 17637ac |
livecode-vulcan
added a commit
that referenced
this pull request
Apr 17, 2019
…-pic [[ Prebuilt ]] Build Linux prebuilt libraries with position-independant code This patch enables the `-fPIC` option when compiling Linux prebuilt libraries, allowing those libraries to be used to create position-independent executables, which is now the default in the version of GCC provided with Ubuntu 18.04.
Contributor
|
😞 test failure 17637ac
|
Member
|
@livecode-vulcan retry 17637ac |
livecode-vulcan
added a commit
that referenced
this pull request
Apr 17, 2019
…-pic [[ Prebuilt ]] Build Linux prebuilt libraries with position-independant code This patch enables the `-fPIC` option when compiling Linux prebuilt libraries, allowing those libraries to be used to create position-independent executables, which is now the default in the version of GCC provided with Ubuntu 18.04.
Contributor
|
😎 test success 17637ac
|
Contributor
|
I can no longer build from source, as I'm getting linker errors on all the prebuilt libraries of the form /usr/bin/ld: ../../prebuilt/lib/linux/x86_64/libpcre.a(pcre16_compile.o): |
Contributor
|
Was this actually tested? |
Contributor
|
@mwieder you could feasibly have some stale thirdparty prebuilts. Try trashing them and rebuilding. |
Contributor
|
Hmmm... "make clean-linux" trashes prebuilt/fetched, prebuilt/include, prebuilt/include, and prebuilt/lib. Is there maybe more work it should be doing? |
Contributor
|
I got rid of everything in prebuilt/packed with the same results. |
Contributor
|
OK @livecodeian any thoughts on this? |
Contributor
Author
|
@mwieder @montegoulding I did a test build at the weekend and got the same results as Mark. Investigating I realised the configuration for building thirdparty prebuilt libs didn't include the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enables the
-fPICoption when compiling Linux prebuilt libraries, allowing those libraries to be used to create position-independent executables, which is now the default in the version of GCC provided with Ubuntu 18.04.