Improving backend - #1
Merged
Merged
Conversation
added 12 commits
September 28, 2015 15:42
…s already been passed into response body.
… java-jwt fire any exception now it is encapsulated in this one. The java-jwt throws some exceptions when the token is invalid. Because of that we need to use this TokenException to catch when token is invalid.
…ted. The sets of content type and character encoding were moved to begin of method because it is the same in "if" and "else" statements.
…ecessary just if we need to pass headers to next filter (or servlet). Added try catch to JWTUtil.decode, because we need to know when token is invalid (and send error to the frontend).
…ends with "login". If yes it just go to next filter, if not, it does the filter logic.
Owner
Author
|
@Pompeu, I made a lot of changes in the backend. Take a look on it and give your review :) |
Pompeu
pushed a commit
that referenced
this pull request
Sep 29, 2015
Improving backend, nice pr, now if i change anyting i will made a pr too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many updates to improve backend code.