Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: linyatis/hello-jwt-java-angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: linyatis/hello-jwt-java-angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 10 files changed
  • 2 contributors

Commits on Sep 28, 2015

  1. Removing unused imports

    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    9103cbc View commit details
    Browse the repository at this point in the history

  2. Removed authorization header from success login response. The token i… 

    …s already been passed into response body.
    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    02f9920 View commit details
    Browse the repository at this point in the history

  3. Adding throws for the exception created "TokenException", so when the… 

    … java-jwt fire any exception now it is encapsulated in this one.

The java-jwt throws some exceptions when the token is invalid. Because of that we need to use this TokenException to catch when token is invalid.
    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    e0d96ad View commit details
    Browse the repository at this point in the history

  4. Created wrappers SimpleMessage and SimpleToken to be used with Gson.t… 

    …oJson().
    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    1eba1ad View commit details
    Browse the repository at this point in the history

  5. Changing implementation to use the SimpleMessage and SimpleToken crea… 

    …ted.

The sets of content type and character encoding were moved to begin of method because it is the same in "if" and "else" statements.
    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    ea21707 View commit details
    Browse the repository at this point in the history

  6. Changing implementation to use the wrapper SimpleMessage created.

    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    2b81c7f View commit details
    Browse the repository at this point in the history

  7. Removing HttpServletRequestWrapper from AuthenticationFilter. It is n… 

    …ecessary just if we need to pass headers to next filter (or servlet).

Added try catch to JWTUtil.decode, because we need to know when token is invalid (and send error to the frontend).
    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    a90070d View commit details
    Browse the repository at this point in the history

  8. Small refactoring just to comply with changes in the backend

    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    5f523da View commit details
    Browse the repository at this point in the history

  9. Removing ByeServlet, as this is not been used.

    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    ebd9f29 View commit details
    Browse the repository at this point in the history

  10. Added checking for public request. In this case, we check if the URI … 

    …ends with "login". If yes it just go to next filter, if not, it does the filter logic.
    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    9a563e8 View commit details
    Browse the repository at this point in the history

  11. Changed LoginServlet URI to "/api/login".

    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    a491bb2 View commit details
    Browse the repository at this point in the history

  12. Small refactoring to comply with backend changes on route.

    José Filipe Lyra
    José Filipe Lyra committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    b3b7002 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2015

  1. Merge pull request #1 from linyatis/improving-backend 

    Improving backend, nice pr, now if i change anyting i will made a pr too.
    Itacir Ferreira Pompeu
    Itacir Ferreira Pompeu committed Sep 29, 2015
    Configuration menu
    Copy the full SHA
    444465a View commit details
    Browse the repository at this point in the history
Loading