Skip to content

Language support - #33

Closed
thelamer wants to merge 2 commits into
masterfrom
langs
Closed

Language support#33
thelamer wants to merge 2 commits into
masterfrom
langs

Conversation

@thelamer

@thelamer thelamer commented Aug 9, 2023

Copy link
Copy Markdown
Member

This one is up for debate, it adds 100 megs to the image because of the cjk font install and langpack download.

Firefox is unique as it does not use system level languages, you have to go out and manually ingest their system extensions to get a translated UI.

With these changes the user can simply pass the LC_ALL env var and the container will be in their language.

@thelamer
thelamer requested a review from a team August 9, 2023 23:43
@LinuxServer-CI

Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/firefox/116.0-r0-pkg-5f4e0677-dev-f1fd07a6dcd2d0deb9f84a2f8775d235975dfb92-pr-33/index.html
https://ci-tests.linuxserver.io/lspipepr/firefox/116.0-r0-pkg-5f4e0677-dev-f1fd07a6dcd2d0deb9f84a2f8775d235975dfb92-pr-33/shellcheck-result.xml

Tag Passed
amd64-116.0-r0-pkg-5f4e0677-dev-f1fd07a6dcd2d0deb9f84a2f8775d235975dfb92-pr-33
arm64v8-116.0-r0-pkg-5f4e0677-dev-f1fd07a6dcd2d0deb9f84a2f8775d235975dfb92-pr-33

@Roxedus

Roxedus commented Aug 10, 2023

Copy link
Copy Markdown
Member

We could offer better language support on a separate tag.

@thelamer

Copy link
Copy Markdown
Member Author

We could offer better language support on a separate tag.

That is not a bad idea

@thelamer

Copy link
Copy Markdown
Member Author

I think I have a way to integrate this in the universal translation mod.

@thelamer thelamer closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants