Skip to content

Add helper for mods - #95

Merged
aptalca merged 1 commit into
masterfrom
mod-helper
Dec 29, 2021
Merged

Add helper for mods#95
aptalca merged 1 commit into
masterfrom
mod-helper

Conversation

@Roxedus

@Roxedus Roxedus commented Dec 29, 2021

Copy link
Copy Markdown
Member

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Adds a helper-function in $PATH for extension installation

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@Roxedus
Roxedus requested a review from a team December 29, 2021 20:03
@thespad

thespad commented Dec 29, 2021

Copy link
Copy Markdown
Member

Should we document this in the app setup as well as the changelog note?

@LinuxServer-CI

Copy link
Copy Markdown
Collaborator

@Roxedus

Roxedus commented Dec 29, 2021

Copy link
Copy Markdown
Member Author

Im on the fence for documenting a function not intended for that type of use(even though I made sure it worked)

@thespad thespad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aptalca
aptalca merged commit 0a12acb into master Dec 29, 2021
@aptalca
aptalca deleted the mod-helper branch December 29, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants