Skip to content

patches/6.19: cameras: add dw9719 i2c_device_id table fix #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toor11 wants to merge 2 commits into
base: master
Choose a base branch
from
+51 −2
Open

patches/6.19: cameras: add dw9719 i2c_device_id table fix #2123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2510749
patches/6.19: cameras: add dw9719 i2c_device_id table fix
toor11 May 11, 2026
e52ed90
patches/6.19: cameras: fix dw9719 i2c_device_id hunk line numbers
toor11 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 51 additions & 2 deletions patches/6.19/0013-cameras.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,56 @@ index f5456330b..3418ff475 100644
+ },
{} /* Terminating entry */
};
--

--
2.53.0

From 0000000000000000000000000000000000000001 Mon Sep 17 00:00:00 2001
From: Sakari Ailus <[email protected]>
Date: Thu, 26 Mar 2026 17:49:09 +0000
Subject: [PATCH] media: i2c: dw9719: Add I2C device ID table

The I2C device id table is necessary as the device may be, besides
through system firmware, also instantiated in the IPU bridge so
matching takes place using the I2C device id table.

Without this table, Surface devices using the dw9719 VCM (voice coil
motor for autofocus) fail to bind the VCM driver. On Surface Book 2
and similar devices, this prevents the ipu3-cio2 notifier from
completing, leaving cameras without media links and with no V4L2
subdevice nodes — so libcamera reports no cameras.

Link: https://lore.kernel.org/all/[email protected]/
Signed-off-by: Sakari Ailus <[email protected]>
Patchset: cameras
---
drivers/media/i2c/dw9719.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/dw9719.c b/drivers/media/i2c/dw9719.c
--- a/drivers/media/i2c/dw9719.c
+++ b/drivers/media/i2c/dw9719.c
@@ -454,6 +454,15 @@ static const struct of_device_id dw9719_of_table[] = {
};
MODULE_DEVICE_TABLE(of, dw9719_of_table);

+static const struct i2c_device_id dw9719_id_table[] = {
+ { .name = "dw9718s", .driver_data = (kernel_ulong_t)DW9718S },
+ { .name = "dw9719", .driver_data = (kernel_ulong_t)DW9719 },
+ { .name = "dw9761", .driver_data = (kernel_ulong_t)DW9761 },
+ { .name = "dw9800k", .driver_data = (kernel_ulong_t)DW9800K },
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, dw9719_id_table);
+
static DEFINE_RUNTIME_DEV_PM_OPS(dw9719_pm_ops, dw9719_suspend, dw9719_resume,
NULL);

@@ -466,4 +475,5 @@ static struct i2c_driver dw9719_i2c_driver = {
.probe = dw9719_probe,
.remove = dw9719_remove,
+ .id_table = dw9719_id_table,
};
module_i2c_driver(dw9719_i2c_driver);
--
2.53.0