patches/6.19: cameras: add dw9719 i2c_device_id table fix#2123
Open
toor11 wants to merge 2 commits into
Open
Conversation
The i2c_device_id table was removed from the dw9719 VCM driver in kernel 6.19 as 'unused', but it is required for Surface devices where the VCM is instantiated via the I2C bus by the IPU bridge. Without this table, the dw9719 driver fails to bind to the VCM device (MODALIAS i2c:dw9719), preventing cio2_notifier_complete() from running, leaving cameras without media links and V4L2 subdevice nodes. libcamera then reports no cameras. Fixes: linux-surface#2087 Fixes: linux-surface#2101 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Adjust line numbers in the dw9719 i2c_device_id patch to account for the 3 lines added by the preceding dw9719 probe delay patch at line 121. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This was referenced May 11, 2026
|
I didn't create an issue for it, but I see the same behaviour on my Surface Book 1, and have confirmed the front camera is re-enabled with this patch and correctly shows an image. (The rear camera is detected after applying this patch, but shows only a green screen if selected in the fedora f44 gnome camera app). |
Author
|
Thanks for testing on Surface Book 1! Great to see the fix working for the front camera. The green screen on the rear camera is likely a separate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds back the
i2c_device_idtable to the dw9719 VCM driver for kernel 6.19, fixing a regression that prevents cameras from working on Surface devices that use the dw9719 voice coil motor (ov8865 autofocus).Root cause: Upstream commit "media: i2c: dw9719: Remove unused i2c device id table" in kernel 6.19 removed the
i2c_device_idtable. However, on Surface devices, the VCM is instantiated by the IPU bridge via I2C, so it requires I2C device matching. Without the table,dw9719_i2c_driverhas noi2c:dw9719alias and the driver never binds.Cascade failure: Without the VCM bound,
cio2_notifier_complete()does not fire, sov4l2_device_register_subdev_nodes()is never called. The ipu3-csi2 entities get no V4L2 subdevice nodes, and libcamera reports "Skip ipu3-csi2 0: no device node" → empty camera list.This patch is taken from Sakari Ailus's upstream fix:
https://lore.kernel.org/all/[email protected]/
Affected issues
Test plan
modinfo dw9719showsalias: i2c:dw9719(and dw9718s, dw9761, dw9800k)media-ctl -pshows links between sensor entities and ipu3-csi2cam --listreports cameras on Surface Book 2 / Surface Go 2 / Surface Pro 8+