Fe code challenge nenadviranov#5
Closed
nenadviranov wants to merge 12 commits intolindar-open:mainfrom
nenadviranov:fe-code-challenge-nenadviranov
Closed
Fe code challenge nenadviranov#5nenadviranov wants to merge 12 commits intolindar-open:mainfrom nenadviranov:fe-code-challenge-nenadviranov
nenadviranov wants to merge 12 commits intolindar-open:mainfrom
nenadviranov:fe-code-challenge-nenadviranov
Conversation
nenadviranov
commented
Nov 22, 2024
nenadviranov
commented
- visually replicated the card
- card container visually replicated
- card container made scrollable
- responsiveness and layout change done
- "+info" functionality done
- selected card stays when navigating around the app
- wrapped complicated func in useMemo and wrapped components in memo
- formatting currency done.
- added suspense and lazy loading for improving initial loading time
- race condition fixed
added 12 commits
November 22, 2024 17:40
…formatted the currency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.