Mark Dagostino: MrQ Lindar Challenge#10
Closed
MarkDa03 wants to merge 15 commits intolindar-open:mainfrom
Closed
Conversation
…n and lazy load views Added Extra Info on Initial Card Fixed +Info Option on Header
…ol state management
Updated SymbolsView layout to support desktop view (price chart on the right) and mobile view CSS Adhered to BEM
…inactive states & Styling (Box Shadow); Updated formatNumber function to show decimal places under $10
…ss of the container
- Implemented Custom Hook for Flash Effect - Improvements to dashboard visuals to be as accurate as possible
- easter egg
Updated Personal Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is my implementation of the MrQ Lindar Challenge. I've tried my best to replicate my implementation as close as possible to the one shown in the instructions, keeping in mind the most efficient approach. I've attempted to implement all suggestions provided, including the Race Condition fix, Utilizing Redux for persisting the active state of the card, and reducing the initial bundle size with Suspense and React.lazy
Types of changes
A more detailed explanation on certain problems and results can be found here:
frontend/notes.md
How has this been tested?
This has been tested on local environment on Windows and on MacOS.
Responsiveness has been tested rigorously on different viewports
Screenshots
Desktop:

Mobile:

Checklist: