examples: additions and fixes by petersalomonsen · Pull Request #5421 · libgit2/libgit2

petersalomonsen · 2020-02-24T17:32:35Z

here's the example fixes / additions from my emscripten PR as requested in #5345 (comment)

add example for git commit
fix example for git add
add example for git push

pks-t · 2020-02-24T20:40:21Z

I will review this after v1.0 is released. Please feel free to ping me after the release if I forget.

pks-t

Thanks a lot for these examples, I'm always happy to extend what we have. There's a few comments I'd like to address, but I'm happy to merge this in the future.

pks-t · 2020-04-01T15:42:42Z

+	const char *comment = argv[2];
+	int error;
+
+    git_oid commit_oid,tree_oid;


This line is indented with spaces

pks-t · 2020-04-01T15:43:08Z

+	git_revparse_ext(&parent, &ref, repo, "HEAD");
+	git_repository_index(&index, repo);	
+	git_index_write_tree(&tree_oid, index);
+	git_index_write(index);


All of the above commands should be checked for errors.

pks-t · 2020-04-01T15:43:35Z

+	(void)repo; /* unused */
+
+	/* Validate args */
+	if (argc < 3 || strcmp(opt, "-m")!=0) {


Please add a space before and after !=

pks-t · 2020-04-01T15:44:18Z

+		const git_error *err = git_error_last();
+		if (err) printf("ERROR %d: %s\n", err->klass, err->message);
+		else printf("ERROR %d: no detailed info\n", error);
+	}


You can use check_lg2 in general for any kind of error checking.

pks-t · 2020-04-01T15:44:43Z

+    const git_strarray refspecs = {
+		&refspec,
+		1,
+	};


There's some formatting errors above with regards to whitespace. We also always use /* */ even for single-line comments, same below.

pks-t · 2020-04-01T15:45:35Z

+		const git_error *err = git_error_last();
+		if (err) printf("ERROR %d: %s\n", err->klass, err->message);
+		else printf("ERROR %d: no detailed info\n", error);
+	}


If you use check_lg2, then you don't need this block. so please also use it fo r git_remote_lookup and git_push_options_init.

petersalomonsen · 2020-04-01T19:01:22Z

Thanks for reviewing @pks-t . I believe the issues are resolved now. For commit I had to handle GIT_ENOTFOUND differently ( empty repositories have no commits ), but elsewhere I've used check_lg2 for error handling. Please let me know if there are still issues.

pks-t

Sorry to be nitpicky, but there's some more style issues I'd like to have fixed before merging. Looks fine to me otherwise :)

pks-t · 2020-04-02T11:42:11Z

+	git_reference *ref = NULL;
+	git_signature *signature;	
+
+	(void)repo; /* unused */


This line can be removed, you use the repo ;)

pks-t · 2020-04-02T11:42:44Z

+	}
+
+	error = git_revparse_ext(&parent, &ref, repo, "HEAD");
+	if ( error == GIT_ENOTFOUND) {


There's a stray space here in between ( error

pks-t · 2020-04-02T11:43:26Z

+
+	check_lg2(git_tree_lookup(&tree, repo, &tree_oid), "Error looking up tree", NULL);
+
+	git_signature_default(&signature, repo);


This also requires error checking.

pks-t · 2020-04-02T11:44:16Z

+
+	check_lg2(git_push_options_init( &options, GIT_PUSH_OPTIONS_VERSION ), "Error initializing push", NULL);
+
+	check_lg2(git_remote_push( remote, &refspecs, &options), "Error pushing", NULL);


There's a few more stray spaces in these commands :)

pks-t · 2020-04-02T11:45:35Z

+	check_lg2(git_index_write_tree(&tree_oid, index), "Could not write tree", NULL);;
+	check_lg2(git_index_write(index), "Could not write index", NULL);;
+
+	git_index_free(index);


I'd move this line before the return error to not disturb the program's business logic flowing and make it easier to understand

add example for git commit fix example for git add add example for git push

petersalomonsen · 2020-04-02T17:09:13Z

yeah, no problem being nitpicky :-) quality is important, and I feel a bit novice on the code conventions here - so very happy for your guidance :-) Think I got the issues resolved now, but let me know if there are more :-)

pks-t

Cool, thanks a lot for these examples!

pks-t · 2020-04-04T11:36:20Z

yeah, no problem being nitpicky :-) quality is important, and I feel a bit novice on the code conventions here - so very happy for your guidance :-) Think I got the issues resolved now, but let me know if there are more :-)

That's on us, though. We don't have a style guide anywhere, so newcomers are left guessing. We should definitely have one, but I've been saying that for a few years now and never just sat down and wrote one.

aaronfranke · 2021-04-17T06:51:16Z

The push example always fails for me. I tested pushing to remotes on GitHub, GitLab, and a local repo on my desktop. I always get -1 returned from git_remote_push when push to a remote on server, and -8 when pushing to the repo on my desktop. I tried the refspec as refs/heads/master and refs/heads/master:refs/remotes/myremote/master, both fail. The git_remote_lookup and git_push_options_init methods always succeed and return 0.

After doing some testing with pushing to a local remote on my desktop, I've isolated the failure: transport->push fails inside of do_push inside of git_push_finish inside of git_remote_upload inside of git_remote_push.

With pushing to both my GitHub and GitLab remotes, it fails in t->connect in git_remote__connect in git_remote_connect in git_remote_push.

For pushing to both my local desktop copy and to GitLab, the error message is: "the transport has not yet loaded the refs"

petersalomonsen requested a review from pks-t February 24, 2020 17:52

pks-t reviewed Apr 1, 2020

View reviewed changes

petersalomonsen force-pushed the examples-fixes-and-additions branch 4 times, most recently from 8642b2c to c73eeed Compare April 1, 2020 18:57

pks-t reviewed Apr 2, 2020

View reviewed changes

examples: additions and fixes

dc2beb7

add example for git commit fix example for git add add example for git push

petersalomonsen force-pushed the examples-fixes-and-additions branch from c73eeed to dc2beb7 Compare April 2, 2020 16:39

pks-t approved these changes Apr 4, 2020

View reviewed changes

pks-t merged commit 7d9b1f0 into libgit2:master Apr 4, 2020

petersalomonsen deleted the examples-fixes-and-additions branch July 19, 2020 05:45


		check_lg2(git_tree_lookup(&tree, repo, &tree_oid), "Error looking up tree", NULL);

		git_signature_default(&signature, repo);


		check_lg2(git_push_options_init( &options, GIT_PUSH_OPTIONS_VERSION ), "Error initializing push", NULL);

		check_lg2(git_remote_push( remote, &refspecs, &options), "Error pushing", NULL);

Conversation

petersalomonsen commented Feb 24, 2020

Uh oh!

pks-t commented Feb 24, 2020

Uh oh!

pks-t left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petersalomonsen commented Apr 1, 2020

Uh oh!

pks-t left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petersalomonsen commented Apr 2, 2020

Uh oh!

pks-t left a comment

Choose a reason for hiding this comment

Uh oh!

pks-t commented Apr 4, 2020

Uh oh!

aaronfranke commented Apr 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aaronfranke commented Apr 17, 2021 •

edited

Loading