LGTM (nightlies-only bionic builds failed because of that). Though I see

/src/deps/ntlmclient/unicode_builtin.c: At top level:
cc1: error: unrecognized command line option '-Wno-documentation-deprecated-sync' [-Werror]
cc1: all warnings being treated as errors

Hopefully this is just a confused GCC ?

Hopefully this is just a confused GCC ?

Yeah, I don't really know where that comes from, but we had that issue since several months already. I've noticed it multiple times, but I've got no idea when exactly it pops up and I didn't think it important enough to really care

I'm happy enough to fix this in ntmlclient itself, if you'd prefer. My goal in building ntlmclient was for it to basically be part of libgit2 (in terms of codestyle, etc) but available for others as well. 🤷‍♂

@ethomson: how about merging this as a short-term fix with the mid-term goal being to fix it in ntlmclient?

Welp, I tried going through unicode_builtin to add /* fallthrough */ comments, but gcc appears confused about the switch-within-a-switch, so... I think that no-implicit-fallthrough is probably the best approach. 🙇